Move settings to a function and add tests

discord_reminder_bot/parser.py

@@ -2,21 +2,22 @@ from __future__ import annotations
 
 import datetime
 import logging
-from zoneinfo import ZoneInfo
+from zoneinfo import ZoneInfo, ZoneInfoNotFoundError
 
 import dateparser
 
-from discord_reminder_bot import settings
+from discord_reminder_bot.settings import get_timezone
 
 logger: logging.Logger = logging.getLogger(__name__)
 
 
-def parse_time(date_to_parse: str, timezone: str | None = None) -> datetime.datetime | None:
+def parse_time(date_to_parse: str, timezone: str | None = None, use_dotenv: bool = True) -> datetime.datetime | None:  # noqa: FBT001, FBT002
     """Parse a date string into a datetime object.
 
     Args:
         date_to_parse(str): The date string to parse.
         timezone(str, optional): The timezone to use. Defaults timezone from settings.
+        use_dotenv(bool, optional): Whether to load environment variables from a .env file. Defaults to True
 
     Returns:
         datetime.datetime: The parsed datetime object.
@@ -28,7 +29,14 @@ def parse_time(date_to_parse: str, timezone: str | None = None) -> datetime.date
         return None
 
     if not timezone:
-        timezone = settings.config_timezone
+        timezone = get_timezone(use_dotenv)
+
+    # Check if the timezone is valid
+    try:
+        tz = ZoneInfo(timezone)
+    except (ZoneInfoNotFoundError, ModuleNotFoundError):
+        logger.error("Invalid timezone provided: '%s'. Using default timezone: '%s'", timezone, get_timezone(use_dotenv))  # noqa: TRY400
+        tz = ZoneInfo("UTC")
 
     try:
         parsed_date: datetime.datetime | None = dateparser.parse(
@@ -37,7 +45,7 @@ def parse_time(date_to_parse: str, timezone: str | None = None) -> datetime.date
                 "PREFER_DATES_FROM": "future",
                 "TIMEZONE": f"{timezone}",
                 "RETURN_AS_TIMEZONE_AWARE": True,
-                "RELATIVE_BASE": datetime.datetime.now(tz=ZoneInfo(timezone)),
+                "RELATIVE_BASE": datetime.datetime.now(tz=tz),
             },
         )
     except (ValueError, TypeError):