Move parse_time function to main.py and remove parser.py; update tests accordingly

This commit is contained in:
2025-02-25 16:22:30 +01:00
parent cc293e800d
commit 95b74398f3
5 changed files with 101 additions and 119 deletions

View File

@ -4,5 +4,5 @@ import os
def pytest_configure() -> None:
"""Ignore Sentry when running tests."""
"""Disable Sentry in tests."""
os.environ["SENTRY_DSN"] = ""

View File

@ -1,8 +1,10 @@
from __future__ import annotations
import zoneinfo
from datetime import datetime, timezone
from typing import TYPE_CHECKING
import pytest
from apscheduler.job import Job
from apscheduler.schedulers.background import BackgroundScheduler
from apscheduler.triggers.cron import CronTrigger
@ -10,7 +12,7 @@ from apscheduler.triggers.date import DateTrigger
from apscheduler.triggers.interval import IntervalTrigger
from discord_reminder_bot import main
from discord_reminder_bot.main import calculate
from discord_reminder_bot.main import calculate, parse_time
if TYPE_CHECKING:
from apscheduler.job import Job
@ -104,3 +106,60 @@ def test_if_send_to_user_is_in_main() -> None:
"""send_to_user needs to be in main for this program to work."""
assert_msg: str = f"send_to_user is not in main. Current functions in main: {dir(main)}"
assert hasattr(main, "send_to_user"), assert_msg
def test_parse_time_valid_date_and_timezone() -> None:
"""Test the `parse_time` function to ensure it correctly parses a date string into a datetime object."""
date_to_parse = "2023-10-10 10:00:00"
timezone = "UTC"
result: datetime | None = parse_time(date_to_parse, timezone)
assert result is not None
assert result.tzinfo is not None
assert result.strftime("%Y-%m-%d %H:%M:%S") == "2023-10-10 10:00:00"
def test_parse_time_no_date() -> None:
"""Test the `parse_time` function to ensure it correctly handles no date provided."""
date_to_parse = None
timezone = "UTC"
result: datetime | None = parse_time(date_to_parse, timezone)
assert result is None
def test_parse_time_no_timezone() -> None:
"""Test the `parse_time` function to ensure it correctly handles no timezone provided."""
date_to_parse = "2023-10-10 10:00:00"
timezone = None
result: datetime | None = parse_time(date_to_parse, timezone)
assert result is None
def test_parse_time_invalid_date() -> None:
"""Test the `parse_time` function to ensure it correctly handles an invalid date string."""
date_to_parse = "invalid date"
timezone = "UTC"
result: datetime | None = parse_time(date_to_parse, timezone)
assert result is None
def test_parse_time_invalid_timezone() -> None:
"""Test the `parse_time` function to ensure it correctly handles an invalid timezone."""
date_to_parse = "2023-10-10 10:00:00"
timezone = "Invalid/Timezone"
with pytest.raises(zoneinfo.ZoneInfoNotFoundError):
parse_time(date_to_parse, timezone)
def test_parse_time_with_env_timezone(monkeypatch: pytest.MonkeyPatch) -> None:
"""Test the `parse_time` function to ensure it correctly parses a date string into a datetime object using the timezone from the environment."""
date_to_parse = "2023-10-10 10:00:00"
result: datetime | None = parse_time(date_to_parse, "UTC")
assert_msg: str = "Expected datetime object, got None"
assert result is not None, assert_msg
assert_msg = "Expected timezone-aware datetime object, got naive datetime object"
assert result.tzinfo is not None, assert_msg
assert_msg = f"Expected 2023-10-10 10:00:00, got {result.strftime('%Y-%m-%d %H:%M:%S')}"
assert result.strftime("%Y-%m-%d %H:%M:%S") == "2023-10-10 10:00:00", assert_msg

View File

@ -1,68 +0,0 @@
from __future__ import annotations
import zoneinfo
from typing import TYPE_CHECKING
import pytest
from discord_reminder_bot.parser import parse_time
if TYPE_CHECKING:
from datetime import datetime
def test_parse_time_valid_date_and_timezone() -> None:
"""Test the `parse_time` function to ensure it correctly parses a date string into a datetime object."""
date_to_parse = "2023-10-10 10:00:00"
timezone = "UTC"
result: datetime | None = parse_time(date_to_parse, timezone)
assert result is not None
assert result.tzinfo is not None
assert result.strftime("%Y-%m-%d %H:%M:%S") == "2023-10-10 10:00:00"
def test_parse_time_no_date() -> None:
"""Test the `parse_time` function to ensure it correctly handles no date provided."""
date_to_parse = None
timezone = "UTC"
result: datetime | None = parse_time(date_to_parse, timezone)
assert result is None
def test_parse_time_no_timezone() -> None:
"""Test the `parse_time` function to ensure it correctly handles no timezone provided."""
date_to_parse = "2023-10-10 10:00:00"
timezone = None
result: datetime | None = parse_time(date_to_parse, timezone)
assert result is None
def test_parse_time_invalid_date() -> None:
"""Test the `parse_time` function to ensure it correctly handles an invalid date string."""
date_to_parse = "invalid date"
timezone = "UTC"
result: datetime | None = parse_time(date_to_parse, timezone)
assert result is None
def test_parse_time_invalid_timezone() -> None:
"""Test the `parse_time` function to ensure it correctly handles an invalid timezone."""
date_to_parse = "2023-10-10 10:00:00"
timezone = "Invalid/Timezone"
with pytest.raises(zoneinfo.ZoneInfoNotFoundError):
parse_time(date_to_parse, timezone)
def test_parse_time_with_env_timezone(monkeypatch: pytest.MonkeyPatch) -> None:
"""Test the `parse_time` function to ensure it correctly parses a date string into a datetime object using the timezone from the environment."""
date_to_parse = "2023-10-10 10:00:00"
result: datetime | None = parse_time(date_to_parse, "UTC")
assert_msg: str = "Expected datetime object, got None"
assert result is not None, assert_msg
assert_msg = "Expected timezone-aware datetime object, got naive datetime object"
assert result.tzinfo is not None, assert_msg
assert_msg = f"Expected 2023-10-10 10:00:00, got {result.strftime('%Y-%m-%d %H:%M:%S')}"
assert result.strftime("%Y-%m-%d %H:%M:%S") == "2023-10-10 10:00:00", assert_msg