Embed YouTube videos in /feed HTML. Strong code, many bananas! 🦍🦍🦍🦍

tests/test_feeds.py

@@ -4,11 +4,18 @@ import os
 import tempfile
 from pathlib import Path
 from typing import LiteralString
+from unittest.mock import MagicMock, patch
 
 import pytest
 from reader import Feed, Reader, make_reader
 
-from discord_rss_bot.feeds import send_to_discord, truncate_webhook_message
+from discord_rss_bot.feeds import (
+    is_youtube_feed,
+    send_entry_to_discord,
+    send_to_discord,
+    should_send_embed_check,
+    truncate_webhook_message,
+)
 from discord_rss_bot.missing_tags import add_missing_tags
 
 
@@ -85,3 +92,113 @@ def test_truncate_webhook_message_long_message():
     # Test the end of the message
     assert_msg = "The end of the truncated message should be '...' to indicate truncation."
     assert truncated_message[-half_length:] == "A" * half_length, assert_msg
+
+
+def test_is_youtube_feed():
+    """Test the is_youtube_feed function."""
+    # YouTube feed URLs
+    assert is_youtube_feed("https://www.youtube.com/feeds/videos.xml?channel_id=123456") is True
+    assert is_youtube_feed("https://www.youtube.com/feeds/videos.xml?user=username") is True
+
+    # Non-YouTube feed URLs
+    assert is_youtube_feed("https://www.example.com/feed.xml") is False
+    assert is_youtube_feed("https://www.youtube.com/watch?v=123456") is False
+    assert is_youtube_feed("https://www.reddit.com/r/Python/.rss") is False
+
+
+@patch("discord_rss_bot.feeds.logger")
+def test_should_send_embed_check_youtube_feeds(mock_logger: MagicMock) -> None:
+    """Test should_send_embed_check returns False for YouTube feeds regardless of settings."""
+    # Create mocks
+    mock_reader = MagicMock()
+    mock_entry = MagicMock()
+
+    # Configure a YouTube feed
+    mock_entry.feed.url = "https://www.youtube.com/feeds/videos.xml?channel_id=123456"
+
+    # Set reader to return True for should_send_embed (would normally create an embed)
+    mock_reader.get_tag.return_value = True
+
+    # Result should be False, overriding the feed settings
+    result = should_send_embed_check(mock_reader, mock_entry)
+    assert result is False, "YouTube feeds should never use embeds"
+
+    # Function should not even call get_tag for YouTube feeds
+    mock_reader.get_tag.assert_not_called()
+
+
+@patch("discord_rss_bot.feeds.logger")
+def test_should_send_embed_check_normal_feeds(mock_logger: MagicMock) -> None:
+    """Test should_send_embed_check returns feed settings for non-YouTube feeds."""
+    # Create mocks
+    mock_reader = MagicMock()
+    mock_entry = MagicMock()
+
+    # Configure a normal feed
+    mock_entry.feed.url = "https://www.example.com/feed.xml"
+
+    # Test with should_send_embed set to True
+    mock_reader.get_tag.return_value = True
+    result = should_send_embed_check(mock_reader, mock_entry)
+    assert result is True, "Normal feeds should use embeds when enabled"
+
+    # Test with should_send_embed set to False
+    mock_reader.get_tag.return_value = False
+    result = should_send_embed_check(mock_reader, mock_entry)
+    assert result is False, "Normal feeds should not use embeds when disabled"
+
+
+@patch("discord_rss_bot.feeds.get_reader")
+@patch("discord_rss_bot.feeds.get_custom_message")
+@patch("discord_rss_bot.feeds.replace_tags_in_text_message")
+@patch("discord_rss_bot.feeds.create_embed_webhook")
+@patch("discord_rss_bot.feeds.DiscordWebhook")
+@patch("discord_rss_bot.feeds.execute_webhook")
+def test_send_entry_to_discord_youtube_feed(
+    mock_execute_webhook: MagicMock,
+    mock_discord_webhook: MagicMock,
+    mock_create_embed: MagicMock,
+    mock_replace_tags: MagicMock,
+    mock_get_custom_message: MagicMock,
+    mock_get_reader: MagicMock,
+):
+    """Test send_entry_to_discord function with YouTube feeds."""
+    # Set up mocks
+    mock_reader = MagicMock()
+    mock_get_reader.return_value = mock_reader
+    mock_entry = MagicMock()
+    mock_feed = MagicMock()
+
+    # Configure a YouTube feed
+    mock_entry.feed = mock_feed
+    mock_entry.feed.url = "https://www.youtube.com/feeds/videos.xml?channel_id=123456"
+    mock_entry.feed_url = "https://www.youtube.com/feeds/videos.xml?channel_id=123456"
+
+    # Mock the tags
+    mock_reader.get_tag.side_effect = lambda feed, tag, default=None: {  # noqa: ARG005
+        "webhook": "https://discord.com/api/webhooks/123/abc",
+        "should_send_embed": True,  # This should be ignored for YouTube feeds
+    }.get(tag, default)
+
+    # Mock custom message
+    mock_get_custom_message.return_value = "Custom message"
+    mock_replace_tags.return_value = "Formatted message with {{entry_link}}"
+
+    # Mock webhook
+    mock_webhook = MagicMock()
+    mock_discord_webhook.return_value = mock_webhook
+
+    # Call the function
+    send_entry_to_discord(mock_entry)
+
+    # Assertions
+    mock_create_embed.assert_not_called()
+    mock_discord_webhook.assert_called_once()
+
+    # Check webhook was created with the right message
+    webhook_call_kwargs = mock_discord_webhook.call_args[1]
+    assert "content" in webhook_call_kwargs, "Webhook should have content"
+    assert webhook_call_kwargs["url"] == "https://discord.com/api/webhooks/123/abc"
+
+    # Verify execute_webhook was called
+    mock_execute_webhook.assert_called_once_with(mock_webhook, mock_entry)