[GH-ISSUE #81] t.co links remain regardless of setting; embedded images are cropped #18

Closed
opened 2026-09-02 13:08:57 +02:00 by TheLovinator · 4 comments
Owner

Originally created by @dziban303 on GitHub (Mar 29, 2023).
Original GitHub issue: https://github.com/TheLovinator1/discord-twitter-webhooks/issues/81

I've tried the DISABLE_REMOVE_TCO_LINKS setting both ways (because it's not super clear which setting does what) but it still provides the t.co link.

Additionally, is it possible to present the attached image in an uncropped format? Discord does apparently support that, because Tweetshift does it:

image

Cheers

Originally created by @dziban303 on GitHub (Mar 29, 2023). Original GitHub issue: https://github.com/TheLovinator1/discord-twitter-webhooks/issues/81 I've tried the `DISABLE_REMOVE_TCO_LINKS` setting both ways (because it's not super clear which setting does what) but it still provides the t.co link. Additionally, is it possible to present the attached image in an uncropped format? Discord does apparently support that, because Tweetshift does it: ![image](https://user-images.githubusercontent.com/7931765/228495780-465d14b0-7c5e-4981-9b1f-953e3dcbdbe8.png) Cheers
Author
Owner

@EthanC commented on GitHub (Mar 30, 2023):

I'm also seeing t.co URLs in the Tweet content, despite DISABLE_REMOVE_TCO_LINKS not being set in my config at all.

@TheLovinator1 It seems the embed attempts to display a gallery of images when there is only one. Maybe if there is only one image, you should just use embed.set_image rather than sending an array with a single image?

image

<!-- gh-comment-id:1489751663 --> @EthanC commented on GitHub (Mar 30, 2023): I'm also seeing `t.co` URLs in the Tweet content, despite `DISABLE_REMOVE_TCO_LINKS` not being set in my config at all. @TheLovinator1 It seems the embed attempts to display a gallery of images when there is only one. Maybe if there is only one image, you should just use `embed.set_image` rather than [sending an array with a single image](https://github.com/TheLovinator1/discord-twitter-webhooks/commit/1a72da5a5693c126da4a550d74d56f0f7a75aed5#diff-43d85680d648061355ccfc1d500f5ce00a08f47ac1d66e80879022ebb33a321cR61)? ![image](https://user-images.githubusercontent.com/16727756/228744864-a876f091-49df-4bf5-8514-bff9377667f9.png)
Author
Owner

@dziban303 commented on GitHub (Mar 30, 2023):

In my testing the other day, it actually did send the unobfuscated link once. I moved on to try another setting. In my next test tweet, the t.co link was back. Changing the other setting (I forget which) back to the default made no difference, the t.co link has remained no matter what I do.

<!-- gh-comment-id:1490578150 --> @dziban303 commented on GitHub (Mar 30, 2023): In my testing the other day, it actually did send the unobfuscated link once. I moved on to try another setting. In my next test tweet, the t.co link was back. Changing the other setting (I forget which) back to the default made no difference, the t.co link has remained no matter what I do.
Author
Owner

@TheLovinator1 commented on GitHub (Mar 31, 2023):

Hi, sorry for the late fix. Both should be working again.

<!-- gh-comment-id:1491253141 --> @TheLovinator1 commented on GitHub (Mar 31, 2023): Hi, sorry for the late fix. Both should be working again.
Author
Owner

@dziban303 commented on GitHub (Apr 1, 2023):

Yep, they're working! Gonna close

<!-- gh-comment-id:1493073349 --> @dziban303 commented on GitHub (Apr 1, 2023): Yep, they're working! Gonna close
Sign in to join this conversation.
No labels
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
TheLovinator/discord-twitter-webhooks#18
No description provided.